Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing ReturnData fields in writeReturnData #2602

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Nov 26, 2024

Closes #2591.

@dweindl dweindl linked an issue Nov 26, 2024 that may be closed by this pull request
@dweindl dweindl force-pushed the fix_2591_writeReturnData branch from a3f0c37 to cfad181 Compare November 26, 2024 14:17
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.59%. Comparing base (c75909d) to head (1430970).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/hdf5.cpp 94.73% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2602      +/-   ##
===========================================
+ Coverage    77.56%   77.59%   +0.03%     
===========================================
  Files          329      329              
  Lines        21637    21693      +56     
  Branches      1470     1477       +7     
===========================================
+ Hits         16782    16832      +50     
- Misses        4844     4850       +6     
  Partials        11       11              
Flag Coverage Δ
cpp 73.46% <94.73%> (+0.04%) ⬆️
cpp_python 34.11% <0.00%> (-0.09%) ⬇️
petab 36.96% <0.00%> (-0.14%) ⬇️
python 72.19% <90.90%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/amici/rdata.h 100.00% <ø> (ø)
src/hdf5.cpp 85.16% <94.73%> (+0.68%) ⬆️

... and 3 files with indirect coverage changes

@dweindl dweindl force-pushed the fix_2591_writeReturnData branch from 4fe2709 to 3029fd0 Compare November 26, 2024 15:25
@dweindl dweindl self-assigned this Nov 26, 2024
@dweindl dweindl force-pushed the fix_2591_writeReturnData branch from f0b9560 to 1430970 Compare November 26, 2024 16:36
@dweindl dweindl marked this pull request as ready for review November 26, 2024 16:39
@dweindl dweindl requested a review from a team as a code owner November 26, 2024 16:40
@dweindl dweindl merged commit 4fcb14d into AMICI-dev:develop Nov 27, 2024
18 of 20 checks passed
@dweindl dweindl deleted the fix_2591_writeReturnData branch November 27, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

writeReturnData doesn't save all ReturnData fields
2 participants